Minor code clean up #4711
Merged
Minor code clean up #4711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
StefanOssendorf
commented
Jul 20, 2025
StefanOssendorf
commented
- Renamed fields to have a _ as prefix
- Changed private readonly property to readonly field
- Use ??= insteaf if if(.. == null)
- Remove unused ctor parameters
- Changed private readonly property to readonly field - Use ??= insteaf if if(.. == null) - Remove unused ctor parameters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs code cleanup across the CSLA framework, focusing on modernizing field naming conventions and simplifying constructor signatures. The changes improve code consistency and reduce constructor complexity while maintaining functionality.
Key changes include:
- Updated private field naming to use underscore prefix convention (
field→_field) - Converted auto-properties to readonly fields where appropriate
- Replaced null-checking patterns with null-coalescing assignment operator (
??=) - Removed unused constructor parameters from DataPortal classes
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/Upgrading to CSLA 10.md | Documents breaking change for DataPortal constructor parameter removal |
| Source/Csla/Server/*.cs | Updated field naming and converted properties to readonly fields in ServicedDataPortal classes |
| Source/Csla/Server/DataPortal.cs | Removed unused constructor parameters, updated field naming, and modernized null-checking |
| Source/Csla/Serialization/Mobile/*.cs | Updated field naming conventions in binary reader/writer classes |
| Source/Csla/Rules/BusinessRules.cs | Updated field naming and modernized conditional statements |
| Source/Csla/DataPortalT.cs | Updated field naming and null-coalescing assignment |
| Source/Csla/DataPortalClient/LocalProxy.cs | Reorganized field declaration and updated references |
| Source/Csla/Core/*.cs | Updated field naming in exception and context manager classes |
| Source/Csla/Configuration/Fluent/DataOptions.cs | Updated field naming and formatting |
| Source/Csla.test/Fakes/Server/DataPortal/TestableDataPortal.cs | Removed unused constructor parameters to match DataPortal changes |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rockfordlhotka
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.